refactor: trim agents to production/ + simulation/, drop site-sim#11
Merged
refactor: trim agents to production/ + simulation/, drop site-sim#11
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Trims Webster's agent surface to a single substrate ahead of the hackathon submission. Site-sim was committed but unused by the demo video. visual-design-critic was a runtime genealogy spawn with no id.txt registration and no production orchestrator references, so removing it brings production back to a clean 9-agent set that mirrors the 9-spec LP-sim set 1:1. Deletions: 9 site-sim agent specs, demo-sites/northwest-reno/, scripts/run-simulation-site.ts, agents/visual-design-critic.json, package.json sim:site, sim-agents.json + memory-stores.json site halves. run-simulation.ts collapses to lp-only literal types and a single-page screenshot path. register-sim-agents.ts/sim-preflight.ts expectations drop from 18→9 sim specs, 2→1 substrate. sim-council.md fan-out drops the SUBSTRATE/AGENT_SET site case and the licensing-and-warranty-critic arm. Affected tests rewritten to LP-only assertions; no tests deleted outright. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Splits the flat agents/*.json layout into two subdirectories so the operational role of each spec is obvious from the path: - agents/production/ — 9 specs that run Nicolette's live council - agents/simulation/ — 9 specs that drive the LP timelapse demo The two sets are now 1:1 symmetric. validate-agents.ts and the schema test recurse through agents/** so the strict Ajv schema gate is preserved without any weakening. Hardcoded paths in critic-genealogy.ts, planner-invoke.ts, and the affected tests are updated to the subdir layout. Genealogy spawns now write into agents/production/ so runtime-spawned critics land beside the rest of the production set. agents/AGENTS.md updated to describe the new shape; agents/CLAUDE.md follows via the existing symlink. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Updates the judge-facing surface and the canonical north-star docs
to match the new single-substrate, 9-agent shape:
- README pitch (7→9 agents), architecture diagram now shows the
full 7-session fan-out (5 critics + monitor + visual-reviewer),
repo layout reflects agents/{production,simulation}/, submission
notes report 9 specs and 175 tests
- AGENTS.md mission says single-substrate Richer Health LP demo
and points the do-not-touch rule at agents/production/
- context/VISION.md drops the dual-substrate framing: the demo arc
is LP-only, memory store count is 6 not 12, the API cost note
scales to one substrate, and the locked/out-of-scope sections
reflect the cut
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
e1f13ba to
951e0b9
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
demo-sites/northwest-reno/,scripts/run-simulation-site.ts, thewebster-site-simhalves of the sim-agents and memory-stores manifests) and the orphan genealogy-spawnedvisual-design-criticso production lands at a clean 9-spec set.agents/*.jsonintoagents/production/andagents/simulation/(9 specs each, 1:1 symmetric) withvalidate-agents.tsrecursing throughagents/**so the strict Ajv schema gate is preserved.AGENTS.md,README.md(7→9 + full architecture diagram + repo-layout block), andcontext/VISION.md(drops dual-substrate framing, memory-store count 12→6, single-substrate scope lock).Validation
bun run validateis green: 19 valid agent/env specs, 7 valid findings, 0 lint warnings, 0 type errors, 0 markdown errors, 175 tests pass / 0 fail.Hackathon framing
The story for judges is now sharper: production is exactly the 9-agent council that runs Nicolette's live LP weekly;
agents/simulation/mirrors it 1:1 to drive the timelapse demo. No second-substrate half-finished surface.Merge-order coordination
Recommend this PR merges to
devbeforefeat/repo-polishSection B (the upcomingagents/README.mdPR), so that README is written against the newagents/{production,simulation}/layout.Test plan
bun run validategreen locallywebster-site-sim/northwest-reno/licensing-and-warranty-criticreferences remain in functional code or the judge-facing surface🤖 Generated with Claude Code